Title: This is nothing very specific to arm.
On 05/22/2018 07:34 AM, Jan Beulich wrote:
Stefano Stabellini <sstabell...@kernel.org> 05/22/18 2:53 AM >>>
All the UART drivers are silent options. Add one line descriptions so
that can be de/selected via menuconfig.
Signed-off-by: Stefano Stabellini <sstabell...@kernel.org>
Please don't forget to Cc maintainers.
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -1,11 +1,11 @@
config HAS_NS16550
- bool
+ bool "NS16550 UART driver"
Here as well as ...
@@ -53,7 +53,8 @@ config HAS_SCIF
or Renesas R-Car Gen 2/3 based board say Y.
>
config HAS_EHCI
- bool
+ bool "EHCI UART driver"
... here iirc Julien had already pointed out that the drivers should not become
optional on x86, i.e. in the former case you want to attach a conditional to the
prompt while in the latter case I don't see why you add the prompt in the first
place if you mean to make it x86-specific. Which by itself is questionable
though: Why would this driver be x86-specific, when so far it (consciously)
hasn't been? If anything I could see it depend on HAS_PCI.
I don't expect this piece of hardware to come up on Arm. Furthermore
HAS_PCI will get selected at some point by Arm. But we need to avoid
selecting that driver. The solution I can see here is keeping the
architecture selecting the option as it is done today.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
