On 12.07.2021 18:21, Anthony PERARD wrote: > On Wed, Jul 07, 2021 at 05:40:02PM +0200, Jan Beulich wrote: >> On 01.07.2021 16:09, Anthony PERARD wrote: >>> And thus avoiding checking for those variable over and over again. >>> >>> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> >> >> Acked-by: Jan Beulich <jbeul...@suse.com> >> in its present shape since all you do is move existing logic. But I >> wonder if I could talk you into ... >> >>> +ifneq ($(origin verbose),undefined) >>> +$(error "You must use 'make menuconfig' to enable/disable verbose now.") >>> +endif >> >> ... doing away with the misleading mentioning of just "menuconfig" here. >> There are various other *config targets, many of which are also suitable >> for the purpose. Personally I've used menuconfig (in Linux) the last >> time perhaps 15 years ago, and hence I have almost forgotten about its >> existence. IOW at the very least I'd see us insert "e.g." everywhere. > > Hopefully, no one ever hits those error anymore, it's been 5 years it > seems since the changes has been made. > > But I can write instead: > "You must use e.g. 'make menuconfig' to enable/disable verbose now." > or maybe: > "You must use Kconfig with e.g. 'make menuconfig' to enable/disable > verbose now." > ?
Either would be fine with me, with a slight preference to the shorter form. Jan
