On 01.07.2021 16:09, Anthony PERARD wrote: > And thus avoiding checking for those variable over and over again. > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
Acked-by: Jan Beulich <jbeul...@suse.com> in its present shape since all you do is move existing logic. But I wonder if I could talk you into ... > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -56,6 +56,28 @@ include scripts/Kbuild.include > ifneq ($(root-make-done),y) > # section to run before calling Rules.mk, but only once. > > +ifneq ($(origin crash_debug),undefined) > +$(error "You must use 'make menuconfig' to enable/disable crash_debug now.") > +endif > +ifeq ($(origin debug),command line) > +$(warning "You must use 'make menuconfig' to enable/disable debug now.") > +endif > +ifneq ($(origin frame_pointer),undefined) > +$(error "You must use 'make menuconfig' to enable/disable frame_pointer > now.") > +endif > +ifneq ($(origin kexec),undefined) > +$(error "You must use 'make menuconfig' to enable/disable kexec now.") > +endif > +ifneq ($(origin lock_profile),undefined) > +$(error "You must use 'make menuconfig' to enable/disable lock_profile now.") > +endif > +ifneq ($(origin perfc),undefined) > +$(error "You must use 'make menuconfig' to enable/disable perfc now.") > +endif > +ifneq ($(origin verbose),undefined) > +$(error "You must use 'make menuconfig' to enable/disable verbose now.") > +endif ... doing away with the misleading mentioning of just "menuconfig" here. There are various other *config targets, many of which are also suitable for the purpose. Personally I've used menuconfig (in Linux) the last time perhaps 15 years ago, and hence I have almost forgotten about its existence. IOW at the very least I'd see us insert "e.g." everywhere. Jan
