On 01.07.2021 16:09, Anthony PERARD wrote: > --- a/xen/test/Makefile > +++ b/xen/test/Makefile > @@ -4,15 +4,10 @@ tests all: build > > ifneq ($(XEN_TARGET_ARCH),x86_32) > # Xen 32-bit x86 hypervisor no longer supported, so has no test livepatches > -SUBDIRS += livepatch > +subdir-y += livepatch > endif
As per xen/Rules.mk having subdir-y := $(subdir-y) $(filter %/, $(obj-y)) obj-y := $(patsubst %/, %/built_in.o, $(obj-y)) ... subdir-obj-y := $(filter %/built_in.o, $(obj-y)) this will result in building of livepatch/built_in.o afaict. Is this an intended but benign side effect? > install build subtree-force-update uninstall: %: > - set -e; for s in $(SUBDIRS); do \ > + set -e; for s in $(subdir-y); do \ > $(MAKE) -f $(BASEDIR)/Rules.mk -C $$s $*; \ > done > - > -clean:: > - set -e; for s in $(SUBDIRS); do \ > - $(MAKE) -f $(BASEDIR)/Rules.mk -C $$s $@; \ > - done And then why can't the generic recursion rule in xen/Rules.mk not also be used for the "build" target? (I guess "install" and "uninstall" need to remain separate, and don't think I know what "subtree-force-update" is about.) Jan
