On 01.07.2021 16:09, Anthony PERARD wrote: > This replace the use of a single .c file use for multiple .o file by > creating multiple .c file including the first one. > > There's quite a few issues with trying to build more than one object > file from a single source file: there's is a duplication of the make > rules to generate those targets; there is an additional ".file" symbol > added in order to differentiate between the object files; and the > tools/symbols have an heuristic to try to pick up the right ".file". > > This patch adds new .c source file which avoid the need to add a > second ".file" symbol and thus avoid the need to deal with those > issues.
While I have to admit that I'm not really happy about these extra new files, I can see that one might view this as the less bad of two evils. > xen/Makefile | 11 ----------- > xen/Rules.mk | 2 +- > xen/arch/x86/mm/Makefile | 9 --------- > xen/arch/x86/mm/guest_walk.c | 3 --- > xen/arch/x86/mm/guest_walk_2.c | 2 ++ > xen/arch/x86/mm/guest_walk_3.c | 2 ++ > xen/arch/x86/mm/guest_walk_4.c | 2 ++ > xen/arch/x86/mm/hap/Makefile | 9 --------- > xen/arch/x86/mm/hap/guest_walk.c | 3 --- > xen/arch/x86/mm/hap/guest_walk_2level.c | 2 ++ > xen/arch/x86/mm/hap/guest_walk_3level.c | 2 ++ > xen/arch/x86/mm/hap/guest_walk_4level.c | 2 ++ Is there a particular reason you've kept the "level" in these three file names? Preferably with them shortened (and ideally dashes used everywhere in the new file names instead of underscores) Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan
