On 01.07.2021 16:09, Anthony PERARD wrote: > Improvement are: > - give the path to xlat.lst as argument > - include `grep -v` in compat-build-source.py script, we don't need to > write this in several scripted language. > > Also remove dependency on Makefile as the file generation doesn't > depend on it anymore.
Did it before any more? In the subsequent patch I can see more of a reason to drop the dependency, but neither there nor here I'm really convinced: In general I think every generate file would better depend on the makefile containing the rule used for its building, as a change to that rule means the target wants rebuilding. Therefore for the moment ... > No changes in final compat/%.h headers. > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > Acked-by: Jan Beulich <jbeul...@suse.com> ... this holds only with the dependency kept in place. But I'll be happy to get convinced otherwise. Jan
