On Wed, Jul 07, 2021 at 04:25:33PM +0200, Jan Beulich wrote: > On 01.07.2021 16:09, Anthony PERARD wrote: > > In Arm and X86 makefile, generating the linker script is the same, so > > we can simply have both call the same macro. > > > > We need to add *.lds files into extra-y so that Rules.mk can find the > > .*.cmd dependency file and load it. > > > > Change made to the command line: > > - Use cpp_flags macro which simply filter -Wa,% options from $(a_flags). > > - Added -D__LINKER__ even it is only used by Arm's lds. > > I'm not really happy about this, not the least because the symbol's name > doesn't fit its purpose (we're not linking, but producing a linker script > at that stage), but well ...
Also, the leading "__" is probably a bad idea as I think it's reserved? I'll look at adding creating a patch which would rename that to LINKER_SCRIPT which seems more appropriate. > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > > Reviewed-by: Jan Beulich <jbeul...@suse.com> Thanks, -- Anthony PERARD
