>>> On 10.01.17 at 07:57, <suravee.suthikulpa...@amd.com> wrote: > On 01/05/2017 10:53 PM, Jan Beulich wrote: >>>>> On 31.12.16 at 06:45, <suravee.suthikulpa...@amd.com> wrote: >>> Expose vlapic_read_aligned and vlapic_reg_write() to be used by AVIC. >>> >>> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> >>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> >> >> Generally I dislike functions being non-static when all their callers >> live in the same file. Therefore it would be better (and hardly >> harder to review) if they got made non-static at the point of their >> first external use. That'll also help understanding whether that's >> an appropriate move. > > IIUC, you want these changes to be in the same patch of the one making > use of them externally.
Yes. > I can certainly combine this patch with patch 6/10. Thanks. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
