> --- a/docs/man/xl.pod.1
> +++ b/docs/man/xl.pod.1
...
> + COLO support in xl is still in experimental (proof-of-concept) phase.
> + There is no support for network or disk at the moment.
I think you need to spell out the lack of storage and network handling
means that the guest will corrupt its disk and confuse its network
peers.
> @@ -875,7 +890,10 @@ int libxl_domain_remus_start(libxl_ctx *ctx,
> libxl_domain_remus_info *info,
> dss->live = 1;
> dss->debug = 0;
> dss->remus = info;
> - dss->checkpointed_stream = LIBXL_CHECKPOINTED_STREAM_REMUS;
> + if (libxl_defbool_val(info->colo))
> + dss->checkpointed_stream = LIBXL_CHECKPOINTED_STREAM_COLO;
> + else
> + dss->checkpointed_stream = LIBXL_CHECKPOINTED_STREAM_REMUS;
If you prefer, a ? : expression would do here as well.
+ dss->checkpointed_stream =
libxl_defbool_val() ? LIBXL_CHECKPOINTED_STREAM_COLO :...
(only completed with sensible formatting). Up to you - it's fine as
it is, too.
Most of this patch looks good to me.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
