> -----Original Message----- > From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] > Sent: Friday, March 20, 2015 7:44 PM > To: Ian Campbell; Xu, Quan > Cc: ke...@koconnor.net; xen-devel@lists.xen.org; qemu-de...@nongnu.org; > stefano.stabell...@eu.citrix.com > Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for > HVM virtual machine > > On 03/19/2015 08:56 AM, Ian Campbell wrote: > > On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: > >> @@ -151,6 +152,8 @@ device_hardware_setup(void) > >> esp_scsi_setup(); > >> megasas_setup(); > >> pvscsi_setup(); > >> + if (runningOnXen()) > >> + vtpm4hvm_setup(); > > Is there anything which is actually Xen specific about the driver in > > tpm.[ch]? Would it be better to just probe for it, perhaps gates by a > > Kconfig option which enables TPM support. > > I also think the probing should be done. That code can also be recycled from > what > I posted earlier. It's gated by a Kconfig option, so it doesn't fill up the > 128k ROM. > > Stefan > Agree, I will do it ASAP.
Quan > > > > And following that train of thought I think you could reasonable drop > > "4hvm" from the name. And possibly even the leading "v", since I > > suppose seabios shouldn't really care if the tpm is emulated or real > > so long as it looks like a real tpm. > > > > Ian. > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
