On 03/19/2015 09:35 PM, Xu, Quan wrote:
-----Original Message-----
From: Ian Campbell [mailto:ian.campb...@citrix.com]
Sent: Thursday, March 19, 2015 8:57 PM
To: Xu, Quan
Cc: ke...@koconnor.net; stef...@linux.vnet.ibm.com; xen-devel@lists.xen.org;
qemu-de...@nongnu.org; stefano.stabell...@eu.citrix.com
Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for
HVM virtual machine
On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote:
@@ -151,6 +152,8 @@ device_hardware_setup(void)
esp_scsi_setup();
megasas_setup();
pvscsi_setup();
+ if (runningOnXen())
+ vtpm4hvm_setup();
Is there anything which is actually Xen specific about the driver in tpm.[ch]?
Would it be better to just probe for it, perhaps gates by a Kconfig option which
enables TPM support.
And following that train of thought I think you could reasonable drop "4hvm"
from the name. And possibly even the leading "v", since I suppose seabios
shouldn't really care if the tpm is emulated or real so long as it looks like a
real
tpm.
Ian.
Thanks for your review. Make sense.
Quan
From previously posted patches you should be able to take 1/8 with the
driver:
http://www.seabios.org/pipermail/seabios/2014-July/008179.html
2/8 added ACPI support, but this is not necessary; it contained the
probing parts, which could be merged into 1.
3/8 was doing TPM initialization, so that should be recyclable as well:
http://www.seabios.org/pipermail/seabios/2014-July/008180.html
I have a set of patches that removes the ACPI part in 2/8, though didn't
post it.
Stefan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
