> -----Original Message----- > From: Ian Campbell [mailto:ian.campb...@citrix.com] > Sent: Thursday, March 19, 2015 8:57 PM > To: Xu, Quan > Cc: ke...@koconnor.net; stef...@linux.vnet.ibm.com; xen-devel@lists.xen.org; > qemu-de...@nongnu.org; stefano.stabell...@eu.citrix.com > Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for > HVM virtual machine > > On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: > > @@ -151,6 +152,8 @@ device_hardware_setup(void) > > esp_scsi_setup(); > > megasas_setup(); > > pvscsi_setup(); > > + if (runningOnXen()) > > + vtpm4hvm_setup(); > > Is there anything which is actually Xen specific about the driver in tpm.[ch]? > Would it be better to just probe for it, perhaps gates by a Kconfig option > which > enables TPM support. > > And following that train of thought I think you could reasonable drop "4hvm" > from the name. And possibly even the leading "v", since I suppose seabios > shouldn't really care if the tpm is emulated or real so long as it looks like > a real > tpm. > > Ian.
Thanks for your review. Make sense. Quan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
