>>> On 28.08.17 at 22:40, <boris.ostrov...@oracle.com> wrote: > @@ -943,6 +944,8 @@ static struct page_info *alloc_heap_pages( > > check_low_mem_virq(); > > + spin_unlock(&heap_lock); > + > if ( d != NULL ) > d->last_alloc_node = node;
I'm not sure about the placement - as long as there's only a single heap lock it certainly also protects the last_alloc_node updates visible in context here. The consumer of this field also holds the heap lock afaict, so at least for the moment it would feel more safe if you moved the unlock past that update. With that feel free to add Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
