>>> On 29.08.17 at 15:12, <boris.ostrov...@oracle.com> wrote:
> On 08/29/2017 07:51 AM, Wei Liu wrote:
>> On Mon, Aug 28, 2017 at 04:40:26PM -0400, Boris Ostrovsky wrote:
>>> scrub_heap_pages() does early return if boot-time scrubbing is
>>> disabled, neglecting to initialize lowmem VIRQ.
>>>
>>> Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com>
>> Seems more appropriate to lift the call to setup_low_mem_virq to the
>> caller of scrub_heap_pages.
>
> setup_low_mem_virq() is only useful in page_alloc.c so I'd rather keep
> it static there.
>
> What I could do is create something like
>
> void heap_init_late(void)
> {
> setup_low_mem_virq();
>
> if ( opt_bootscrub )
> scrub_heap_pages();
> }
Ah, yes, that's what I've outlined in the other reply just sent.
Don't forget the __init, though.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
