>>> On 29.08.17 at 13:51, <wei.l...@citrix.com> wrote: > On Mon, Aug 28, 2017 at 04:40:26PM -0400, Boris Ostrovsky wrote: >> scrub_heap_pages() does early return if boot-time scrubbing is >> disabled, neglecting to initialize lowmem VIRQ. >> >> Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> > > Seems more appropriate to lift the call to setup_low_mem_virq to the > caller of scrub_heap_pages.
That's not a good idea imo, as that would mean replicating the code in ARM and x86. I'd rather see the early return to become an ordinary if (skipping the rest of the function, preferably without goto). Or, mainly to limit code churn, introduce a new wrapper function (of perhaps a different name, as setup_low_mem_virq() has nothing to do with scrubbing anyway) and move the setup_low_mem_virq() call there, making scrub_heap_pages() static. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
