At 16:58 +0100 on 23 Aug (1503507504), Wei Liu wrote:
> After 404595352 ("x86/paging: Enforce PG_external == PG_translate ==
> PG_refcounts"), PG_refcounts and PG_translate always need to be set
> together.
>
> Squash PG_refcounts to simplify code. All calls paging_mode_refcounts
> are replaced by calls to paging_mode_translate.
Would it be a good idea to merge all three and have only PG_external?
> Signed-off-by: Wei Liu <wei.l...@citrix.com>
Acked-by: Tim Deegan <t...@xen.org>
with one adjustment:
> /* common paging mode bits */
> #define PG_mode_shift 10
> -/* Refcounts based on shadow tables instead of guest tables */
> -#define PG_refcounts (XEN_DOMCTL_SHADOW_ENABLE_REFCOUNT << PG_mode_shift)
> /* Enable log dirty mode */
> #define PG_log_dirty (XEN_DOMCTL_SHADOW_ENABLE_LOG_DIRTY << PG_mode_shift)
> /* Xen does p2m translation, not guest */
Please add "and handles refcounts" to the comment describing PG_translate.
Cheers,
Tim.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
