On Wed, Aug 23, 2017 at 04:58:24PM +0100, Wei Liu wrote:
> After 404595352 ("x86/paging: Enforce PG_external == PG_translate ==
> PG_refcounts"), PG_refcounts and PG_translate always need to be set
> together.
>
> Squash PG_refcounts to simplify code. All calls paging_mode_refcounts
> are replaced by calls to paging_mode_translate.
>
> Signed-off-by: Wei Liu <wei.l...@citrix.com>
> ---
> Cc: George Dunlap <george.dun...@eu.citrix.com>
> Cc: Tim Deegan <t...@xen.org>
> Cc: Jan Beulich <jbeul...@suse.com>
> Cc: Andrew Cooper <andrew.coop...@citrix.com>
> ---
> xen/arch/x86/domain.c | 6 ++----
> xen/arch/x86/hvm/hvm.c | 2 +-
> xen/arch/x86/mm.c | 20 ++++++++++----------
> xen/arch/x86/mm/paging.c | 8 +++-----
> xen/include/asm-x86/paging.h | 5 +----
> xen/include/asm-x86/shadow.h | 2 +-
> 6 files changed, 18 insertions(+), 25 deletions(-)
>
> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
> index 9b4b9596d8..bbe545b165 100644
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -1017,8 +1017,6 @@ int arch_set_info_guest(
>
> if ( !cr3_page )
> rc = -EINVAL;
> - else if ( paging_mode_refcounts(d) )
> - /* nothing */;
It appears I accidentally deleted this hunk, but my tests were still
happy...
Given this function is rather convoluted I intend to add it back and
deal with that later.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
