Le Wednesday 06 February 2008 03:18:20 RCL, vous avez écrit :
> Hey,
>
> What do you think about these patches?
>
> 1) Sound cache - I implemented some easy caching scheme which greatly helps
> on my FreeBSD (especially noticeable with
> e.g. Disco grenade). May be noticeable under Linux/Windows, too.
>
> 2) Cluster bazooka - a simple weapon that works like cluster bomb, but uses
> rockets. Clusters follow the direction of rocket 'carrier'.
> I gave a bit more info on forum:
> http://www.wormux.org/forum/viewtopic.php?pid=2373#p2373
>
> I'm curious what do you think about my patches:
>
> a) do they fit your coding style?

As Kurosu already told you, actually there's no coding style in wormux and as 
Kurosu told you, there's one style per dev here :)

Maybe I'll try to send something in mailing list to start something ...

> b) do you think they can be incorporated in game?

Of course !

> c) is it comfortable to submit patches like this (frankly, it's the first
> time I contribute to open-source project).

If you think you can work on other part of the project you can even get a svn 
access. It's up to you :)

>
> Thanks in advance,
> Dmitry 'RCL' Rekman

Wow ! Thanks for your contribution !

As far as I can see, your patch are great and it seems there's no big matter 
into it.

Anyway, I'll try to take some time to test it and maybe push it against our 
trunk.

Regards,

Yannig (drayan)

_______________________________________________
Wormux-dev mailing list
Wormux-dev@gna.org
https://mail.gna.org/listinfo/wormux-dev

Répondre à