Hi again! RCL a écrit : > What do you think about these patches?
I had started to reply in the forum, but whatever :) > 1) Sound cache - I implemented some easy caching scheme which greatly helps > on my FreeBSD (especially noticeable with e.g. Disco grenade). May be > noticeable under Linux/Windows, too. I did notice lag on explosion, but I thought it was the animation that was very costly. As a result, some reports about slowness might be more related to HD speed than CPU's. I'm all for integration, and the evicting scheme I thought in the forum is probably unneeded. I'll check how much memory is needed, but images and their zoomed/rotated versions probably take ten times as much anyway. > 2) Cluster bazooka - a simple weapon that works like cluster bomb, but uses > rockets. Clusters follow the direction of rocket 'carrier'. > I gave a bit more info on forum: > http://www.wormux.org/forum/viewtopic.php?pid=2373#p2373 I hadn't replied because I had no idea. I don't see any good reason to not include it (haven't looked at the code itself). One minor issue not related to that weapon alone is the one hinted at in: http://gna.org/bugs/?10672 Basically, there could be so many different weapons and it's going to be necessary to sort them out in the end. > a) do they fit your coding style? There's no coding style per se. I have seen about 3 different ones in the wormux code (yours being a 4th one with the extra spaces around function parameters). The only rules I see, if I had to draw some: - use the same coding style in a function, and possibly file - don't use tabs (ok, that's mostly me, but whatever, you seem to agree :) And overall, from my point of view, it looks sane, and the code quality is good. > b) do you think they can be incorporated in game? Personally, yes. I'll work on integrating the sound cache, which will just be cosmetics (trailing whitespaces). > c) is it comfortable to submit patches like this (frankly, it's the first > time I contribute to open-source project). As you wish, but indeed the mailing list helps making it reviewed by more people. Best regards, -- Kurosu _______________________________________________ Wormux-dev mailing list Wormux-dev@gna.org https://mail.gna.org/listinfo/wormux-dev
