"Jeroen De Dauw" posted a comment on MediaWiki.r111264. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111264#c30833
Commit summary for MediaWiki.r111264: adding DBDataObject class after having some people review it and posting on the list. docs can currently be found at https://www.mediawiki.org/wiki/User:Jeroen_De_Dauw/DBDataObject Jeroen De Dauw's comment: I'll have to correct myself there. The original reason for having $wgDBDataObjects is not gone. It's there to also be able to automatically add prefixes for tables that do not have their own class in joins (typically tables that just link stuff). I'm actually not convinced myself that this join code is any good. Where all other code in this class makes stuff easier, this is one place where it just adds hassle. So I'm thinking of just throwing that out, after which the class can return to using overriding of the methods you mentioned. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
