"Platonides" posted a comment on MediaWiki.r111264. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111264#c30824
Commit summary for MediaWiki.r111264: adding DBDataObject class after having some people review it and posting on the list. docs can currently be found at https://www.mediawiki.org/wiki/User:Jeroen_De_Dauw/DBDataObject Platonides's comment: I'm not convinced about this class. For one, why use $wgDBDataObjects if each object will need to get its own class anyway? It's easier to override both getDBTable() and getFieldPrefix() Then there's the way in how it tries to load half-columns. I assume each instance corresponds to a table row? If a system needs to load the same row twice, it's very likely that someone was coded wrong. I'm not saying we shouldn't support that, but I'd log such thing. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
