"Jeroen De Dauw" posted a comment on MediaWiki.r111264.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111264#c30830

Commit summary for MediaWiki.r111264:

adding DBDataObject class after having some people review it and posting on the 
list. docs can currently be found at 
https://www.mediawiki.org/wiki/User:Jeroen_De_Dauw/DBDataObject

Jeroen De Dauw's comment:

> It's easier to override both getDBTable() and getFieldPrefix() 

This is actually what it originally did. The reason why I changed it is gone 
now, so this could easily be changed back. This really is a implementation 
detail that does not affect the rest of the code at all, so judging the class 
on that seems odd :)

> I assume each instance corresponds to a table row?

Yeah it does.

> Then there's the way in how it tries to load half-columns. 

Sorry, I'm not following you here. half-columns? Are you referring to the fact 
that you can choose to load only a subset of the fields?

> If a system needs to load the same row twice, it's very likely that someone 
> was coded wrong.

Load it twice? Huh? It does not need to do this...

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to