"Catrope" changed the status of MediaWiki.r105916 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105916#c27629
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r105916:
updating FundraisingStatistics to use summary table
Catrope's comment:
<pre>
+ date_default_timezone_set( 'UTC' );
</pre>
Again, this is a hack you shouldn't need. See r105641 CR.
<pre>
+ if ( mysql_num_rows( mysql_query( "SHOW TABLES LIKE
'public_reporting_days'" ) ) ) {
</pre>
Never ever ever use <code>mysql_*()</code> functions directly. You could have
done this with <code>$res = $dbr->query( "SHOW TABLES ... " ); if (
$res->numRows() )</code> if you really wanted to, but we've got
<code>$dbr->tableExists()</code> so use that.
OK otherwise.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
