"Kaldari" changed the status of MediaWiki.r105916 to "new" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105916#c27778

Old Status: fixme
> New Status: new

Commit summary for MediaWiki.r105916:

updating FundraisingStatistics to use summary table

Kaldari's comment:

I've left in the hack for now (as it works and doesn't cause any problems). I 
have a good idea of how to implement that differently though. The only trick is 
that in some contexts we want end time minus 24 hours (the date of the end), 
and in some contexts we want the exact end time (which is actually the 
beginning of the day after the end day). So what to set in the config isn't 
obvious if we're asking for a timestamp. I have a good idea for how to address 
this though.

The mysql function problem is fixed though. Changing status to new since we're 
hoping to get this out the door today.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to