"Catrope" changed the status of MediaWiki.r105659 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105659#c27628
Old Status: new > New Status: fixme Commit summary for MediaWiki.r105659: make parserfunction based on fundraiser ID instead of start time, start using the new summary tables, add some comments Catrope's comment: <pre> + $dbr = efContributionReportingConnection(); + + // If a total is cached, use that + $key = wfMemcKey( 'contributionreportingtotal', $fundraiser, $fudgeFactor ); </pre> It would be slightly more efficient to only open the DB connection after having checked memcached, so you don't open DB connections for memc hits. <pre> + 'prf_id = ' . $myFundraiser['id'], </pre> Please use <code>'prf_id' => $myFundraiser['id']</code> . OK otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
