Review: Needs Fixing

I think this is broken in the current state. The problem is that logic depends 
on available_supply which is a multimap. The problem is that the map is sorted 
by distance, then by a pointer. 

In a replay or in a multiplayer games, the order of elements in this map is 
different, yielding therefore different routing results. This will desync the 
game.

Change the ordering to use a tie-breaker, for example the game object id before 
the pointer. 
-- 
https://code.launchpad.net/~widelands-dev/widelands/request_supply_opt/+merge/280193
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/request_supply_opt.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to