> On Dec. 25, 2015, 10:11 p.m., Andreas Kotes wrote: > > scripts/vagrant/setup-fedora.sh, line 21 > > <https://reviews.apache.org/r/41700/diff/1-2/?file=1175988#file1175988line21> > > > > Ubuntu is using OpenJDK 7? > > > > Don't care either way, but should be consistent.
offically wave is only jdk 7 atm, but since were upto date with gwt we can do jdk 8. fedora itself onl have enough man power to maintain one jdk which will keep us on our toes in the future ;). Ill update all configs to use jdk 8 for a future investment in the upgrade of wave since it compiles fine just has 3 warnings. - Evan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41700/#review111896 ----------------------------------------------------------- On Dec. 25, 2015, 11:11 a.m., Evan Hughes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41700/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2015, 11:11 a.m.) > > > Review request for wave, Ali Lown and Yuri Zelikov. > > > Repository: wave > > > Description > ------- > > Adds vagrant config for linux and windows vm's > > > Diffs > ----- > > .gitignore b8ef753 > README.md 3be1780 > Vagrantfile PRE-CREATION > release/artifact-sign.sh 004d5f0 > scripts/release/artifact-sign.sh PRE-CREATION > scripts/vagrant/application.conf PRE-CREATION > scripts/vagrant/setup-fedora.sh PRE-CREATION > scripts/vagrant/setup-ubuntu.sh PRE-CREATION > scripts/vagrant/setup-win-choco.cmd PRE-CREATION > scripts/vagrant/setup-win.cmd PRE-CREATION > wave/build.gradle ca39a6d > wave/config/reference.conf 04753c4 > > Diff: https://reviews.apache.org/r/41700/diff/ > > > Testing > ------- > > Can run server in all vm's (fedora, ubuntu, win 10) > > > Thanks, > > Evan Hughes > >
