----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41700/#review111896 -----------------------------------------------------------
Well-meant nitpicking :) scripts/vagrant/setup-fedora.sh (line 21) <https://reviews.apache.org/r/41700/#comment172188> Ubuntu is using OpenJDK 7? Don't care either way, but should be consistent. scripts/vagrant/setup-fedora.sh (line 31) <https://reviews.apache.org/r/41700/#comment172189> I like it - but the path for the config-file scraped differs between Ubuntu and Fedora? - Andreas Kotes On Dez. 25, 2015, 11:11 vorm., Evan Hughes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41700/ > ----------------------------------------------------------- > > (Updated Dez. 25, 2015, 11:11 vorm.) > > > Review request for wave, Ali Lown and Yuri Zelikov. > > > Repository: wave > > > Description > ------- > > Adds vagrant config for linux and windows vm's > > > Diffs > ----- > > .gitignore b8ef753 > README.md 3be1780 > Vagrantfile PRE-CREATION > release/artifact-sign.sh 004d5f0 > scripts/release/artifact-sign.sh PRE-CREATION > scripts/vagrant/application.conf PRE-CREATION > scripts/vagrant/setup-fedora.sh PRE-CREATION > scripts/vagrant/setup-ubuntu.sh PRE-CREATION > scripts/vagrant/setup-win-choco.cmd PRE-CREATION > scripts/vagrant/setup-win.cmd PRE-CREATION > wave/build.gradle ca39a6d > wave/config/reference.conf 04753c4 > > Diff: https://reviews.apache.org/r/41700/diff/ > > > Testing > ------- > > Can run server in all vm's (fedora, ubuntu, win 10) > > > Thanks, > > Evan Hughes > >
