-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41700/#review111876
-----------------------------------------------------------

Ship it!


Worked for me on OSX - used ubuntu vm.
The only issue - it requires to run as root. But can be improved later.


scripts/vagrant/application.conf (line 1)
<https://reviews.apache.org/r/41700/#comment172167>

    in this file you can override the settings in reference.conf - no need to 
specify everything.


- Yuri Zelikov


On Dec. 24, 2015, 4:19 a.m., Evan Hughes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41700/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2015, 4:19 a.m.)
> 
> 
> Review request for wave, Ali Lown and Yuri Zelikov.
> 
> 
> Repository: wave
> 
> 
> Description
> -------
> 
> Adds vagrant config for linux and windows vm's
> 
> 
> Diffs
> -----
> 
>   .gitignore b8ef753 
>   README.md 3be1780 
>   Vagrantfile PRE-CREATION 
>   release/artifact-sign.sh 004d5f0 
>   scripts/release/artifact-sign.sh PRE-CREATION 
>   scripts/vagrant/application.conf PRE-CREATION 
>   scripts/vagrant/setup-fedora.sh PRE-CREATION 
>   scripts/vagrant/setup-ubuntu.sh PRE-CREATION 
>   scripts/vagrant/setup-win-choco.cmd PRE-CREATION 
>   scripts/vagrant/setup-win.cmd PRE-CREATION 
>   wave/build.gradle ca39a6d 
> 
> Diff: https://reviews.apache.org/r/41700/diff/
> 
> 
> Testing
> -------
> 
> Can run server in all vm's (fedora, ubuntu, win 10)
> 
> 
> Thanks,
> 
> Evan Hughes
> 
>

Reply via email to