Ok so infra has basically said the practical answer is to just commit the patch, unless we want to wait for the issue to be fixed, which could be a while. So unless anyone has any problems with that I suggest you just go for it Ali.
Thanks Angus Turner angusisf...@gmail.com On Sun, Nov 25, 2012 at 7:05 AM, Upayavira <u...@odoko.co.uk> wrote: > sign on to #asfinfra on freenode, and ask there, if you can. > > Upayavira > > On Fri, Nov 23, 2012, at 09:10 PM, Angus Turner wrote: > > Seems it is indeed something on the reviewboard side. Anyone know where > > we > > should go with this? > > Thanks > > Angus Turner > > angusisf...@gmail.com > > > > > > On Sat, Nov 24, 2012 at 7:59 AM, Angus Turner <angusisf...@gmail.com> > > wrote: > > > > > Ok all, > > > I tried contacting infra with no luck, i'm not sure if my message > didn't > > > get through or what. I think it might be worth just creating a new > review > > > request so i'll try that next. > > > Thanks > > > Angus Turner > > > angusisf...@gmail.com > > > > > > > > > > > > On Mon, Nov 19, 2012 at 10:22 AM, Angus Turner <angusisf...@gmail.com > >wrote: > > > > > >> I'll leave it for 10 minutes or so and see what happens. > > >> Thanks > > >> Angus Turner > > >> angusisf...@gmail.com > > >> > > >> > > >> > > >> On Mon, Nov 19, 2012 at 10:19 AM, Ali Lown <a...@lown.me.uk> wrote: > > >> > > >>> Timeout related? > > >>> > > >>> Might it be worth mentioning to infrastructure? > > >>> > > >>> Ali > > >>> > > >>> On 18 November 2012 23:17, Angus Turner <angusisf...@gmail.com> > wrote: > > >>> > It's getting there. It seems a 4.4mb patch breaks the review system > > >>> though > > >>> > :) > > >>> > Thanks > > >>> > Angus Turner > > >>> > angusisf...@gmail.com > > >>> > > > >>> > > > >>> > > > >>> > On Mon, Nov 19, 2012 at 10:04 AM, Angus Turner < > angusisf...@gmail.com> > > >>> > wrote: > > >>> >> > > >>> >> Great I'll upload it now. > > >>> >> Thanks > > >>> >> Angus Turner > > >>> >> angusisf...@gmail.com > > >>> >> > > >>> >> > > >>> >> > > >>> >> On Mon, Nov 19, 2012 at 10:02 AM, Ali Lown <a...@lown.me.uk> > wrote: > > >>> >>> > > >>> >>> > It might be easier > > >>> >>> > to download the patch apply that and create a script that just > > >>> adds the > > >>> >>> > extra * needed everywhere. > > >>> >>> > > >>> >>> @Angus, do you want to submit the new patch onto the existing > review > > >>> >>> rather than me making a new review request for the same problem? > > >>> >>> If so, find it attached. > > >>> >>> Note: the perl script I wrote uses the header formatting > specified in > > >>> >>> the Apache document[0], which wraps the text in a different > location > > >>> >>> (and indents the URL consistently) from your script, so it is > quite a > > >>> >>> long patch. > > >>> >>> I don't think it broke anything, but it is quite possible it did, > > >>> feel > > >>> >>> free to check... :) > > >>> >>> > > >>> >>> Ali > > >>> >>> [0]: https://www.apache.org/legal/src-headers.html > > >>> >> > > >>> >> > > >>> > > > >>> > > >> > > >> > > > >
