Before, it was easier to read but also misleading. Indeed, NAME field was actually empty because the definition of the maccro : "add_vpp_packaging name" was putting "NAME" in "name" and "vomVENDORfd.ioDESCRIPTIONVPP Object Model" in ARGN for parsing by cmake_parse_arguments (cmake>=3.5 only btw).
In the end, the name was properly set thanks to "get_cmake_property(COMPONENTS components)". Now, if someone wants to keep using NAME, VENDOR, DESCRIPTION before the used string, he just needs to copy-paste the code of cmake_parse_arguments macro not to break distribution using cmake earlier than 3.5. Yohan > -----Original Message----- > From: Andrew 👽 Yourtchenko <ayour...@gmail.com> > Sent: vendredi 19 juillet 2019 23:28 > To: Yohan Pipereau (ypiperea) <ypipe...@cisco.com> > Cc: Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) > <vrpo...@cisco.com>; vpp-dev@lists.fd.io > Subject: Re: [vpp-dev] Ubuntu1604 merge job is broken > > Oh cool, seems you are much further on it than me, so I yield to your work. > Thanks for looking ! > > The only (ignorant user) comment is about > https://gerrit.fd.io/r/#/c/20756/4/extras/vom/CMakeLists.txt - seems like it > loses a bit of readability... wonder if there is a way to keep that somehow. > But then as I said above in the parenthesis :) > > > --a > > On 19 Jul 2019, at 23:13, Yohan Pipereau (ypiperea) <ypipe...@cisco.com > <mailto:ypipe...@cisco.com> > wrote: > > > > I am working on having cpack-based packages respect vpp packages > name format: > https://gerrit.fd.io/r/#/c/20756/ . > > The problem comes from add_vpp_packaging rather than vom. > > Yohan > > > > -----Original Message----- > > > From: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > <vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > On Behalf Of Andrew > > > Yourtchenko > > > Sent: vendredi 19 juillet 2019 20:42 > > > To: Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at > Cisco) > > > <vrpo...@cisco.com <mailto:vrpo...@cisco.com> > > > > Cc: vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > > > Subject: Re: [vpp-dev] Ubuntu1604 merge job is broken > > > > > > I reproduced the problem on 16.04, somehow the name is > goofed - it has > > > “Linux” in the package name rather than the standard > architecture name. I > > > suspect vom isn’t really arch-agnostic, so probably it is not a > nice idea to > > > name it this way :-) > > > > > > Interestingly building on 18.04 the name does contain the > architecture but it > > > does look still slightly different from the rest of the > packages. > > > > > > I will dig further on Monday and ping you. > > > > > > > > > --a > > > > > > On 19 Jul 2019, at 10:36, Vratko Polak -X (vrpolak - > PANTHEON > > > TECHNOLOGIES at Cisco) via Lists.Fd.Io > <vrpolak=cisco....@lists.fd.io <mailto:vrpolak=cisco....@lists.fd.io> > > > <mailto:vrpolak=cisco....@lists.fd.io> > wrote: > > > > > > > > > > > > <image001.gif> > > > > > > Paul has already commented [0] on this, > > > > > > hopefully my subject draws more attention. > > > > > > > > > > > > Basically, packagecould does not like the look > > > > > > of ubuntu1604 VOM package, leading not only > > > > > > to missing VOM package, but also other packages > > > > > > unlucky enough to come after VOM in upload order. > > > > > > > > > > > > This includes packages such as vpp-plugin-core. > > > > > > Funnily enough, CSIT tests using ubuntu1604 > > > > > > do not really miss that package. > > > > > > > > > > > > So, who has the knowledge to fix the VOM package? > > > > > > > > > > > > Vratko. > > > > > > > > > > > > [0] https://gerrit.fd.io/r/c/20585/#message- > 1f1876f6_baf3a8c0 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > Links: You receive all messages sent to this group. > > > > > > View/Reply Online (#13526): https://lists.fd.io/g/vpp- > > > dev/message/13526 > > > Mute This Topic: https://lists.fd.io/mt/32524787/675608 > > > Group Owner: vpp-dev+ow...@lists.fd.io > > > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub > > > [ayour...@gmail.com <mailto:ayour...@gmail.com> > <mailto:ayour...@gmail.com> ] > > > -=-=-=-=-=-=-=-=-=-=-=- > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13533): https://lists.fd.io/g/vpp-dev/message/13533 Mute This Topic: https://lists.fd.io/mt/32524787/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
