Eeh, we haven't previously advertised support for VLAN tags on af_packet before; I could believe it was a missing feature, but I have a harder time accepting it was a bug.
I'm not strongly against the merge (though I do have a preference for strongly encouraging people to keep up with releases at this time), but I do want us to be clear about the disposition of this change. Chris. > -----Original Message----- > From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On > Behalf Of prabh...@techtrueup.com > Sent: Friday, September 29, 2017 11:43 > To: Neale Ranns (nranns) <nra...@cisco.com> > Cc: vpp-dev@lists.fd.io > Subject: Re: [vpp-dev] vlan sub interfaces > > well looking at the change it definitely suggests to be a bug fix. > > we are currently using 1707 builds, and dont have plan to move to newer > release right now, so would prefer a merge to 1707. > > Regards, > Prabhjot > > Quoting "Neale Ranns (nranns)" > <nra...@cisco.com>: > > > With my release manager hat on … > > Do we consider support for VLAN tags on an AF packet interface a bug > > fix (to be back ported) or a new feature (available from 17.10 > > onwards)? > > > > /neale > > > > -----Original Message----- > > From: "prabh...@techtrueup.com" <prabh...@techtrueup.com> > > Date: Thursday, 28 September 2017 at 13:07 > > To: "Dave Barach (dbarach)" <dbar...@cisco.com> > > Cc: "Neale Ranns (nranns)" <nra...@cisco.com>, "John Lo (loj)" > > <l...@cisco.com>, "vpp-dev@lists.fd.io" <vpp-dev@lists.fd.io>, Akshaya > > Nadahalli <aksh...@rtbrick.com> > > Subject: Re: [vpp-dev] vlan sub interfaces > > > > yes i verified it on stable/1707 itself. > > > > Regards, > > Prabhjot > > > > Quoting "Dave Barach (dbarach)" <dbar...@cisco.com>: > > > > > See https://gerrit.fd.io/r/#/c/8590. The patch cherry-picked easily > > > to stable/1707. > > > > > > Assuming that the cherry-pick patch validates - and that it solves > > > your problem - it will be up to Neale [as the 17.07 release manager] > > > whether to merge it or not. > > > > > > Please let us know whether the cherry-pick patch works for you. > > > > > > Thanks… Dave > > > > > > From: vpp-dev-boun...@lists.fd.io > > > [mailto:vpp-dev-boun...@lists.fd.io] On Behalf Of Prabhjot Singh Sethi > > > Sent: Thursday, September 28, 2017 3:27 PM > > > To: Akshaya Nadahalli <aksh...@rtbrick.com>; Prabhjot Singh Sethi > > > <prabh...@techtrueup.com>; vpp-dev@lists.fd.io; John Lo (loj) > > > <l...@cisco.com> > > > Subject: Re: [vpp-dev] vlan sub interfaces > > > > > > yes it works perfectly fine with this patch. > > > i hope this will be pushed to 17.07 branch as well. > > > > > > Thanks for the help :) > > > > > > Regards, > > > Prabhjot > > > > > > ----- Original Message ----- > > > From: > > > "Akshaya Nadahalli" > <aksh...@rtbrick.com<mailto:aksh...@rtbrick.com>> > > > > > > To: > > > "Prabhjot Singh Sethi" > > > <prabh...@techtrueup.com<mailto:prabh...@techtrueup.com>>, > > > <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>>, "John Lo" > > > <l...@cisco.com<mailto:l...@cisco.com>> > > > Cc: > > > > > > Sent: > > > Thu, 28 Sep 2017 19:18:50 +0530 > > > Subject: > > > Re: [vpp-dev] vlan sub interfaces > > > > > > > > > Hi Prabhjot, > > > > > > > > > > > > Can you pls try with below patch and see if it helps: > > > > > > https://gerrit.fd.io/r/#/c/8435/ > > > > > > > > > > > > Regards, > > > > > > Akshaya N > > > > > > On Thursday 28 September 2017 03:45 PM, Prabhjot Singh Sethi wrote: > > > trying again with more appropriate subject > > > > > > Can some one please help if i am missing any thing over here ? > > > > > > As mentioned earlier, i have interface host-eth10 and sub interface > > > host-eth10.10 (create sub host-eth10 10) > > > host-eth10 is associated to bridge domain 2 and sub interface is > > > associated to bridge domain 3 > > > when VPP receives tagged packet with vlan 10 it still associates it > > > to bd 2 and not bd 3 > > > > > > Note: if i don't associate any bd with base interface it just drops > > > the packet with some error. > > > > > > Regards, > > > Prabhjot > > > > > > > > > _______________________________________________ > > > vpp-dev mailing list > > > vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> > > > https://lists.fd.io/mailman/listinfo/vpp-dev > > > > > > -- > > > Regards, > > > Akshaya N > > > _______________________________________________ > vpp-dev mailing list > vpp-dev@lists.fd.io > https://lists.fd.io/mailman/listinfo/vpp-dev _______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
