On Mon, 16 Feb 2026 10:59:04 GMT, Aleksey Shipilev <[email protected]> wrote:

>> I think I want the final hunk to be something like:
>> 
>> 
>> @@ -581,18 +582,17 @@ void BytecodeInterpreter::run(interpreterState istate) 
>> {
>>  /* 0xC0 */ &&opc_checkcast,     &&opc_instanceof,       &&opc_monitorenter, 
>>   &&opc_monitorexit,
>>  /* 0xC4 */ &&opc_wide,          &&opc_multianewarray,   &&opc_ifnull,       
>>   &&opc_ifnonnull,
>>  /* 0xC8 */ &&opc_goto_w,        &&opc_jsr_w,            &&opc_breakpoint,   
>>   &&opc_fast_agetfield,
>> -/* 0xCC */ &&opc_fast_bgetfield,&&opc_fast_cgetfield,   
>> &&opc_fast_dgetfield, &&opc_fast_fgetfield,
>> +/* 0xCC */ &&opc_default,       &&opc_fast_bgetfield,   
>> &&opc_fast_cgetfield, &&opc_fast_dgetfield,
>>  
>> -/* 0xD0 */ &&opc_fast_igetfield,&&opc_fast_lgetfield,   
>> &&opc_fast_sgetfield, &&opc_fast_aputfield,
>> -/* 0xD4 */ &&opc_fast_bputfield,&&opc_fast_zputfield,   
>> &&opc_fast_cputfield, &&opc_fast_dputfield,
>> -/* 0xD8 */ &&opc_fast_fputfield,&&opc_fast_iputfield,   
>> &&opc_fast_lputfield, &&opc_fast_sputfield,
>> -/* 0xDC */ &&opc_fast_aload_0,  &&opc_fast_iaccess_0,   
>> &&opc_fast_aaccess_0, &&opc_fast_faccess_0,
>> +/* 0xD0 */ &&opc_fast_fgetfield, &&opc_fast_igetfield,  
>> &&opc_fast_lgetfield, &&opc_fast_sgetfield,
>> +/* 0xD4 */ &&opc_fast_aputfield, &&opc_default,         
>> &&opc_fast_bputfield, &&opc_fast_zputfield,
>> +/* 0xD8 */ &&opc_fast_cputfield, &&opc_fast_dputfield,  
>> &&opc_fast_fputfield, &&opc_fast_iputfield,
>> +/* 0xDC */ &&opc_fast_lputfield, &&opc_fast_sputfield,  &&opc_fast_aload_0, 
>>   &&opc_fast_iaccess_0,
>>  
>> -/* 0xE0 */ &&opc_fast_iload,    &&opc_fast_iload2,      &&opc_fast_icaload, 
>>   &&opc_fast_invokevfinal,
>> -/* 0xE4 */ &&opc_default,       &&opc_default,          &&opc_fast_aldc,    
>>   &&opc_fast_aldc_w,
>> -/* 0xE8 */ &&opc_return_register_finalizer,
>> -                                &&opc_invokehandle,     
>> &&opc_nofast_getfield,&&opc_nofast_putfield,
>> -/* 0xEC */ &&opc_nofast_aload_0,&&opc_nofast_iload,     &&opc_default,      
>>   &&opc_default,
>> +/* 0xE0 */ &&opc_fast_aaccess_0,  &&opc_fast_faccess_0,    
>> &&opc_fast_iload,                &&opc_fast_iload2,
>> +/* 0xE4 */ &&opc_fast_icaload,    &&opc_fast_invokevfinal, &&opc_default,   
>>                 &&opc_default,
>> +/* 0xE8 */ &&opc_fast_aldc,       &&opc_fast_aldc_w,       
>> &&opc_return_register_finalizer, &&opc_invokehandle,
>> +/* 0xEC */ &&opc_nofast_getfield, &&opc_nofast_putfield,   
>> &&opc_nofast_aload_0,            &&opc_nofast_iload,
>>  
>>  /* 0xF0 */ &&opc_default,       &&opc_default,          &&opc_default,      
>>   &&opc_default,
>>  /* 0xF4 */...
>
> [zero-no-whitespace.patch](https://github.com/user-attachments/files/25338434/zero-no-whitespace.patch)
>  should apply on top of your PR, that's how I get to the hunk above.

Thanks I'll push your preferred formatting.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2068#discussion_r2811865541

Reply via email to