On Mon, 16 Feb 2026 10:53:52 GMT, Axel Boldt-Christmas <[email protected]> wrote:
>>> We still need to reformat a large portion of the table >> >> I do not understand this part. What/who says you *need* to reformat the >> table? You can certainly avoid doing whitespace changes, can you not? I have >> just spot-checked a few lines in current diff, and most of the lines I tried >> contain only whitespace changes. Which makes the diff larger than it >> can/should be. > > Is what you want this > https://github.com/openjdk/valhalla/commit/b38f3672d1d2c2f3ecd7b8b48db7be29148662fa > with some effort to keep the table sane, but the columns are unaligned? > > Or this with absolutely no whitespace changes? > ~~https://github.com/openjdk/valhalla/commit/2dba3de2331b6fdb2148c2fc48b4d514045b26f9~~ > > https://github.com/openjdk/valhalla/commit/d39601ddf6b4610a905465f3ea97b01bd6254cc1 > > Or > https://github.com/openjdk/valhalla/commit/59c1fc2e7dedd079a61dced4401267dace7c642d > which is the first version but the columns aligned. (When modifying > structured / aligned tables, variable declarations / definitions, I usually > try to fix their format after the change.) I think https://github.com/openjdk/valhalla/commit/b38f3672d1d2c2f3ecd7b8b48db7be29148662fa got some weird entries, I could have done it a bit better. Also forgot to remove the trailing two entities in ~~https://github.com/openjdk/valhalla/commit/2dba3de2331b6fdb2148c2fc48b4d514045b26f9~~ ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2068#discussion_r2811819243
