On Thu, 29 Jan 2026 09:24:07 GMT, Joel Sikström <[email protected]> wrote:
>> In that case, can we convert the injected check to an assertion? And perhaps
>> see what happens?
>
> I did some local testing and we need the injected check there since the
> injected field is not accounted for in the count of how many fields there are
> in the klass, so it does not have an entry in the `_inline_layout_info_array`.
>
> We could have a check like this, but I'd rather keep only having checks that
> return true, and returning false in the end of the function.
>
> if (fieldinfo.field_flags().is_injected()) {
> return false;
> }
Ok, I agree I'd also prefer to return false at the end. Thanks for looking into
it.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1966#discussion_r2740950918
