On Thu, 29 Jan 2026 08:38:43 GMT, Paul Hübner <[email protected]> wrote:
>> The logic is the same as we had before, I just moved it to this helper. With
>> that said, I'm not sure why we check this, as an injected field should
>> likely not be present in `_inline_layout_info_array` so should not get
>> through this check at all...
>
> In that case, can we convert the injected check to an assertion? And perhaps
> see what happens?
I did some local testing and we need the injected check there since the
injected field is not accounted for in the count of how many fields there are
in the klass, so it does not have an entry in the `_inline_layout_info_array`.
We could have a check like this, but I'd rather keep only having checks that
return true, and returning false in the end of the function.
if (fieldinfo.field_flags().is_injected()) {
return false;
}
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1966#discussion_r2740698455
