On Wed, 28 Jan 2026 12:22:39 GMT, Paul Hübner <[email protected]> wrote:
>> Joel Sikström has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Exception check should really be an assert
>> - Move inlineable check to static helper
>
> src/hotspot/share/classfile/classFileParser.cpp line 6402:
>
>> 6400: // never allocated for an InstanceKlass which has no need for this
>> information.
>> 6401: if (_inline_layout_info_array == nullptr) {
>> 6402: _inline_layout_info_array =
>> MetadataFactory::new_array<InlineLayoutInfo>(_loader_data,
>
> We also have a `set_inline_layout_info_array`. AFAICT it's only used in
> `ClassFileParser::apply_parsed_class_metadata` and
> `InstanceKlass::deallocate_contents`. Maybe it'd be good to keep
> `_inline_layout_info_array` setting consistent.
`set_inline_layout_info_array` is a method in InstanceKlass
(`InstanceKlass::set_inline_layout_info_array`). At this point, and also by the
time we potentially deallocate the array in ClassFileParser, we haven't
transferred ownership of the array to the allocated InstanceKlass yet. We don't
have a method/helper to set/unset `_inline_layout_info_array` in
ClassFileParser.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1966#discussion_r2737136126
