On Mon, 8 Dec 2025 14:25:22 GMT, Quan Anh Mai <[email protected]> wrote:

>> Hi,
>> 
>> This PR fixes various issues with `TypeAryPtr` and `TypeAryKlassPtr`. It 
>> starts with me trying to tighten the properties (`flat`, `null_free`, etc) 
>> of these classes, then fixing all the revealed issues until there are no 
>> crashes or wrong results left.
>> 
>> Please take a look and leave your reviews, thanks a lot.
>
> Quan Anh Mai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   reviews

Thanks for making these changes. Looks all good to me, I only wonder if we 
could cast `init_val` to an InlineTypeNode in LibraryCallKit::inline_newArray 
(see my comment)?

Let's wait for @fparain to approve the change in 
`src/hotspot/share/prims/jvm.cpp`.

-------------

Marked as reviewed by thartmann (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/1755#pullrequestreview-3567728238

Reply via email to