On Mon, 8 Dec 2025 10:24:42 GMT, Tobias Hartmann <[email protected]> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reviews
>
> src/hotspot/share/opto/memnode.cpp line 1355:
>
>> 1353: Node* init_value = ld_alloc->in(AllocateNode::InitValue);
>> 1354: if (init_value != nullptr) {
>> 1355: // TODO 8350865 Scalar replacement does not work well for flat
>> arrays.
>
> Can you re-enable the tests in `TestArrays.java` marked with `// TODO 8350865
> Scalar replacement does not work well for flat arrays` now? There are a few
> more places in the code marked with `// TODO 8350865 Scalar replacement ...`
> as well. We might just want to leave this to
> [JDK-8350865](https://bugs.openjdk.org/browse/JDK-8350865) though.
Simply re-enabling the tests results in failures of scenario 2 due to the
returned oop being kept alive. I will need to look into this a little further.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1755#discussion_r2598828728
