On Wed, 17 Dec 2025 17:37:56 GMT, Quan Anh Mai <[email protected]> wrote:

>> Hi,
>> 
>> This PR fixes various issues with `TypeAryPtr` and `TypeAryKlassPtr`. It 
>> starts with me trying to tighten the properties (`flat`, `null_free`, etc) 
>> of these classes, then fixing all the revealed issues until there are no 
>> crashes or wrong results left.
>> 
>> Please take a look and leave your reviews, thanks a lot.
>
> Quan Anh Mai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix because properties passed into with_properties is not the same as 
> properties() of the result

I had a quick off-thread discussion with Frederic who voiced some concerns: 
ArrayProperties are user requirements and shouldn’t be changed by the JVM, even 
if the chosen layout provides stronger guarantees. However, since your 
normalization only affects atomicity, and non-atomicity is not part of JEP 401, 
it’s OK to proceed for now. Please file a follow-up bug to track these concerns 
though.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1755#issuecomment-3670395208

Reply via email to