Thanks Chris, Mark, I opened an enhancement request about a configurable callback handler - https://bz.apache.org/bugzilla/show_bug.cgi?id=61795 I have included in it a pull request with patch proposal.
Regards, Lazar On Mon, Nov 20, 2017 at 4:24 PM, Christopher Schultz < ch...@christopherschultz.net> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Mark and Lazar, > > On 11/18/17 10:05 AM, Mark Thomas wrote: > > On 18/11/17 14:20, Lazar Kirchev wrote: > >> Hello Marc, > >> > >> Do you think it makes sense to make the CallbackHandler > >> implementation class configurable, e.g. to be able to specify its > >> name via a property? > > > > As a property on the authenticator? I don't see why not. > > +1 > > Also, we should arrange to allow for multiple callback handlers to be > supported. > > >> In this way if support for additional callbacks is necessary > >> someone could plug a custom CallbackHandler providing such a > >> support. The current CallbackHandlerImpl would remain the default > >> one. > >> > >> Regarding jaspic, as I played around a little bit with it I found > >> the following small problems (all bugzilla issues contain also a > >> pull request with a patch proposal): > > Fantastic! Thanks for your contributions! > > - -chris > -----BEGIN PGP SIGNATURE----- > Comment: GPGTools - http://gpgtools.org > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAloS5YkACgkQHPApP6U8 > pFgznxAAl7+ujEV0K520FcIckJFnz8qLnoTRBz5qlCVFJOBAUVBbNL9zJTUs/n6K > /EOVEWmvB26reIvyxprw9UXbhtanukpmYrQ6DWpPsH03z6WIQJhmZ4BXw+XJklJS > YE2A3GldT0+wgArSM00bHjDR6gZaHPuTutO9Gpk0su9uw1Erd41dNj53tYqQ9254 > pNqhS+tsI8ayQ7zMrNHIzR/C/beS3IOURyyAxHL7wGMGBq83O6+l8u0tTzR5+j0t > vFLHa1Q6uVAkofJmOzXehBbX3k7wU6HQdSIXZWcEG8Qhn6i8sjfXJw8cRf7YOIYY > Ou5smdWPWEcnQlYDIUwyMx6+/yXhgUgV6chai+tFsNBLlMjNBCjhVmqXB1Jc9kPK > fRo6KmcPTaCBip5qk4QdtenY7/5Swi+y9SFKu4AXTxsWx2MvVO/Xupp3RsYocybT > 8V8UNmTGbxgRUMyFLjCFN5rPwt6OvgCPle99rMJXtWObGZFdiVL7RhLhoh9mXl8D > tUyATSWG+etqn6xn5VlnI9si10hvPcgkWfPn+nEIEWQAbjoi5UP0f2BaFdk3mX8+ > t+m+AKup3eiHlSxI/YCwotSQ6+3W7AuSPsZ+O31AFAid54zkw7ZUGniYC4w5wwtq > oxIrCOJAmWGbIWotCNlqTm8liV9FhtpzYkNvG/eFIxv9rtsuYm4= > =McTq > -----END PGP SIGNATURE----- > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org > >
