> Do you think it makes sense to make the CallbackHandler implementation
> > class configurable, e.g. to be able to specify its name via a property?
>
> As a property on the authenticator? I don't see why not.


Yes, something like that: https://github.com/apache/tomcat/pull/93



> > In
> > this way if support for additional callbacks is necessary someone could
> > plug a custom CallbackHandler providing such a support. The current
> > CallbackHandlerImpl would remain the default one.
> >
> > Regarding jaspic, as I played around a little bit with it I found the
> > following small problems (all bugzilla issues contain also a pull request
> > with a patch proposal):
>
> Thanks. Hopefully they'll get looked at before the next set of releases.

Thanks. I don't think they are very urgent so it will be OK even if they go
in some later release.

Regards,
Lazar

Reply via email to