Hello Marc, Do you think it makes sense to make the CallbackHandler implementation class configurable, e.g. to be able to specify its name via a property? In this way if support for additional callbacks is necessary someone could plug a custom CallbackHandler providing such a support. The current CallbackHandlerImpl would remain the default one.
Regarding jaspic, as I played around a little bit with it I found the following small problems (all bugzilla issues contain also a pull request with a patch proposal): https://bz.apache.org/bugzilla/show_bug.cgi?id=61777 https://bz.apache.org/bugzilla/show_bug.cgi?id=61778 https://bz.apache.org/bugzilla/show_bug.cgi?id=61779 https://bz.apache.org/bugzilla/show_bug.cgi?id=61780 https://bz.apache.org/bugzilla/show_bug.cgi?id=61781 https://bz.apache.org/bugzilla/show_bug.cgi?id=61782 https://bz.apache.org/bugzilla/show_bug.cgi?id=61783 https://bz.apache.org/bugzilla/show_bug.cgi?id=61784 All fixes are really very small. Regards, Lazar On Wed, Nov 8, 2017 at 5:51 PM, Lazar Kirchev <lazar.kirc...@gmail.com> wrote: > Yes, my mistake - 3.5, not 4.5. But the content is the same. > > Thanks Mark! > > On Wed, Nov 8, 2017 at 5:38 PM, Mark Thomas <ma...@apache.org> wrote: > >> On 08/11/2017 12:00, Lazar Kirchev wrote: >> > Hello, >> > >> > According to the JASSPIC spec version 1.1, chapter 4.5, The >> CallbackHandler >> > should support CallerPrincipalCallback, GroupPrincipalCallback, >> > PasswordValidationCallback, as well as CertStoreCallback, >> > PrivateKeyCallback, SecretKeyCallback and TrustStoreCallback. >> >> Chapter 4 is the SOAP profile. >> >> You want to look at Chapter 3 which is the Servlet Container profile. >> >> > However, in Tomcat 8.5.* >> > org.apache.catalina.authenticator.jaspic.CallbackHandlerImpl supports >> only >> > CallerPrincipalCallback and GroupPrincipalCallback. Are there any plans >> to >> > add support for the others? >> >> There are no plans to extend the JASPIC implementation at this time. >> >> Patches welcome. >> >> Mark >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: users-h...@tomcat.apache.org >> >> >
