On Mon, 1 Dec 2014, John Hardin wrote:
On Mon, 1 Dec 2014, Kevin A. McGrail wrote:
On 12/1/2014 9:21 AM, Burnie wrote:
> But I was thinking another solution to the problem;
>
> Since there already are quite a few changes to 3.4(+) (quite a few
> checking for version >= 3.004000 in the rulesets)
>
> How difficult would it be to split 3.4.1(+) rulesets from pre-3.4.1
> rulesets? Older SA/sa-update would then fetch rulesets without the
> new checks, and new sa-update would benefit from the new checks...
That's a decent amount of work AND a dangerous path to tread because only
3.4.X is supported by the project currently so if we invested a lot of
time on that path, it would lead to dropping 3.3.X support. But it's a
good thought because it is a solution no one else mentioned.
Before we go that route, I have not tested whether a require_version at the
beginning of a separate rules file will bypass this issue.
Ugh, that's actually worse:
Dec 1 10:57:50.092 [23879] warn: config: configuration file
"/home/jhardin/develop/spamassassin/testing/require_version.cf" requires
version 5.003000 of SpamAssassin, but this is code version 3.004001. Maybe you need to
use the -C switch, or remove the old config files? Skipping this file at
lib/Mail/SpamAssassin/Conf/Parser.pm line 406.
Dec 1 10:57:50.092 [23879] info: config: configuration file
"/home/jhardin/develop/spamassassin/testing/require_version.cf" requires
version 5.003000 of SpamAssassin, but this is code version 3.004001. Maybe you need to
use the -C switch, or remove the old config files? Skipping this file
Dec 1 10:57:50.092 [23879] warn: Argument "fnord_should_be_skipped" isn't numeric
in numeric ge (>=) at (eval 2526) line 1.
It emits *more* warnings, and *doesn't* actually skip parsing the
conditional in that file. :(
I suppose the only option is
can(Mail::SpamAssassin::Conf::perl_min_version_5010000) after all.
That's *so* ugly.
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
jhar...@impsec.org FALaholic #11174 pgpk -a jhar...@impsec.org
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
We have to realize that people who run the government can and do
change. Our society and laws must assume that bad people -
criminals even - will run the government, at least part of the
time. -- John Gilmore
-----------------------------------------------------------------------
14 days until Bill of Rights day
