On Mon, 1 Dec 2014, Kevin A. McGrail wrote:
On 12/1/2014 9:21 AM, Burnie wrote:
On 11/30/2014 11:29 PM, John Hardin wrote:
> > Would a corrected syntax version of this work?
> >
> > if version > 3.004001 && perl_version >= 5.010000
> > body NON_588_COMPATIBLE_RE_SYNTAX /\w++/
> > endif
>
> Yes. That *does* work.
>
> Thank you! I think you just solved it.
Define work...
OK, looks like we need to add a single has/can function for perl 5.010000 for
this issue since we can't pass a parameter or use perl_version without
hitting errors. It's not scalable but will solve the immediate issue.
But I was thinking another solution to the problem;
Since there already are quite a few changes to 3.4(+) (quite a few
checking for version >= 3.004000 in the rulesets)
How difficult would it be to split 3.4.1(+) rulesets from pre-3.4.1
rulesets? Older SA/sa-update would then fetch rulesets without the
new checks, and new sa-update would benefit from the new checks...
That's a decent amount of work AND a dangerous path to tread because only
3.4.X is supported by the project currently so if we invested a lot of time
on that path, it would lead to dropping 3.3.X support. But it's a good
thought because it is a solution no one else mentioned.
Before we go that route, I have not tested whether a require_version at
the beginning of a separate rules file will bypass this issue.
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
jhar...@impsec.org FALaholic #11174 pgpk -a jhar...@impsec.org
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
There is no better measure of the unthinking contempt of the
environmentalist movement for civilization than their call to
turn off the lights and sit in the dark. -- Sultan Knish
-----------------------------------------------------------------------
14 days until Bill of Rights day
