Perhaps the rules that need the version check could be put into a separate file that is only used with SA version 3.4.x and above. It might be possible to get the appropriate sa_update patch for older versions through Red Hat, if that is needed. It might not be if 3.3.x does not load rule files marked for 3.4.x. I note there are separate storage areas for rules for various versions. If it's really used that's perhaps the best fix.

(And if I'm thinking as well as I think in the above maybe I should get back to paying work.)

{^_^}

On 2014-11-30 12:49, Dave Pooser wrote:
On 11/30/14, 2:04 PM, "Reindl Harald" <h.rei...@thelounge.net> wrote:

it's *not* about a "crufty version of perl"

it's about a perl version check not existing in SpamAssassin 3.4.0
it's visible on recent perl versions
without the version checks issing the warnings they had no problem

OK, I could have been clearer there. Let me spell out my logic:

1) Red Hat is not going to release a new version of SpamAssassin for their
existing distros. That's not how they roll.
2) Any rule that uses a regex that requires a version of Perl later than
the 2006-era Perl 5.8.8 will cause a fatal sa-update error unless it's
wrapped in a version check
3) Using version_check creates a non-fatal warning on versions of SA =<
3.4.0

So, we have three options
1) Force Red Hat users to endure a warning unless they update their
spamassassin outside of normal distro channels to gain version_check
capabilities
2) Take the version_check out and break sa-update on computers running
older versions of perl
3) Write all spamassassin rules to use the lowest-common-denominator perl,
which would be the "crufty version of perl" I referred to above.

Do you see a fourth option?

Reply via email to