Re: Argument "perl_version" isn't numeric

[Reindl Harald]

Am 30.11.2014 um 22:22 schrieb Reindl Harald:

Am 30.11.2014 um 22:13 schrieb John Hardin:

On Sun, 30 Nov 2014, Reindl Harald wrote:

5)
make the condition to the SA version, there are already ton's of "if
(version > = 3.004000)" rules and so it needs just to depend on SA
bigger than 3.4.0 instead of the perl check

why that would work?
well, older RHEL versions as you said won't upgrade SA or perl
that setups would not use the rule, recent ones would

And anyone who is running SA prior to 3.4.0 on perl newer than 5.8.8
(where it would run just fine) does not get the benefit of the rule, and
anyone running 3.4.0 on perl 5.8.8 (which is entirely possible) has
their sa-update lint blow up and they don't get *any* new rules.

The assumption "newer SA = newer perl" is not really justified

true - at the end of the day "we" need to draw a line and outweight
benefit/drawbacks for each case

the final conclusion can even be "the benefit of a specific rule is not
high enough to beat out the drawbacks" until all possible and reasonable
conditions are evaluated

maybe the same rule result could be achived with a not that nice syntax
working with older SA as well perl versions and if that's not possible
the question "is it really worth the trouble" remains

what i mean if there is no better solution: there is hardly a new rule
that from one day to the next will stop a reasonable large amount of
spam not already caught by the summary of other rules

additionally if you have the "if perl_version" *inside* a "if version" and only apply it that way to SA >= 3.4.0 the warnings at least would only occur on systems with a old perl and recent SA which is hopefully the minority from my knowledge the "if perl_version" should not get touched in that case at all, at least in the interpreted languages i am working with a "and" condition is evaluated from left to right and the right oart is skipped if the left one is negative the currect rolled out rule affects pretty recent SA running with pretty recent perl and that's a not reasonable penalty

signature.asc
Description: OpenPGP digital signature