+1 Nice improvement.
-Jay On Tue, Feb 14, 2017 at 1:22 PM, Steven Schlansker < sschlans...@opentable.com> wrote: > Hi, it looks like I have 2 of the 3 minimum votes, can a third voter > please consider this KIP? > Thanks. > > (PS - new revision on GitHub PR with hopefully the last round of > improvements) > > > On Feb 8, 2017, at 9:06 PM, Matthias J. Sax <matth...@confluent.io> > wrote: > > > > +1 > > > > On 2/8/17 4:51 PM, Gwen Shapira wrote: > >> +1 (binding) > >> > >> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker > >> <sschlans...@opentable.com> wrote: > >>> Hi everyone, > >>> > >>> Thank you for constructive feedback on KIP-121, > KStream.peek(ForeachAction<K, V>) ; > >>> it seems like it is time to call a vote which I hope will pass easily > :) > >>> > >>> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 121%3A+Add+KStream+peek+method > >>> > >>> I believe the PR attached is already in good shape to consider merging: > >>> > >>> https://github.com/apache/kafka/pull/2493 > >>> > >>> Thanks! > >>> Steven > >>> > >> > >> > >> > > > >
