d/rules: override_dh_auto_test: ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) # Generate a root CA and server certificate for testing ./utils/gen-test-certs.sh # Avoid race conditions in upstream testsuite ./runtest --clients 1 --verbose --dump-logs --tls || true timeout 30m ./runtest-cluster --tls || true ./runtest-sentinel || true # Clean up after gen-test-certs.sh rm -rf tests/tls || true # Other cleanup find tests/tmp ! -name .gitignore -type f -exec rm -rfv {} + endif
Build-time test failures will not fail the build, since all end in "|| true". This needs improvement. If we have flaky tests, maybe they should be disabled individually? In my test build in a noble container with 8Gb of ram (on the host) had just one failed test, but this "|| true" suffix basically wastes all the time spent on the tests. I'm not yet 100% sure on which test was the real failure, looks like the below: ... 14:48:07> SENTINEL SIMULATE-FAILURE crash-after-election works: OK 14:48:07> (init) Restart killed instances: OK 14:48:07> (init) Remove old master entry from sentinels: OK 14:48:07> (init) Create a master-slaves cluster of 5 instances: OK 14:48:07> (init) Sentinels can start monitoring a master: OK 14:48:07> (init) Sentinels can talk with the master: OK 14:48:07> (init) Sentinels are able to auto-discover other sentinels: OK 14:48:09> (init) Sentinels are able to auto-discover slaves: OK 14:48:09> SENTINEL SIMULATE-FAILURE crash-after-promotion works: OK ERROR: Sentinel has leaked fds to scripts: 29 {/home/ubuntu/git/packages/valkey/valkey/tests/sentinel/tmp/sentinel_0/sentinel.conf (deleted)} ---- Testing unit: 06-ckquorum.tcl 14:48:10> (init) Restart killed instances: OK 14:48:10> (init) Remove old master entry from sentinels: OK ... killing stale instance 34732 killing stale instance 34740 killing stale instance 34846 WARNING 1 test(s) failed. # Clean up after gen-test-certs.sh rm -rf tests/tls || true # Other cleanup find tests/tmp ! -name .gitignore -type f -exec rm -rfv {} + removed 'tests/tmp/resetchannels.acl.11337.142/nodefaultuser.acl' ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2081000 Title: Backport version from Oracular to Noble To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/valkey/+bug/2081000/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs