SRU review

- same content as oracular, bar obvious changelog entry

- version ok

- uscan: NOK
$ uscan --download-current-version
uscan warn: In debian/watch no matching hrefs for version 7.2.51 in watch line
  https://github.com/valkey-io/valkey/tags 
(?:.*?/)?v?(?:[-_]?[Vv]?(\d[\-+\.:\~\da-zA-Z]*))(?i)(?:\.(?:tar\.xz|tar\.bz2|tar\.gz|tar\.zstd?|zip|tgz|tbz|txz))

This is a dfsg source tarball, but without a debian/gbp.conf file for
the exclusions. I suspect only the exclusions from d/copyright are
applied then, correct?

Anyway, this is the diff between upstream's tarball and the one uploaded to New:
$ diff -uNr valkey-7.2.5-upstream/ valkey-7.2.5-git/|diffstat 
 adapters/macosx.h         |  115 
-------------------------------------------------------------------------------------------------------------------
 examples/example-macosx.c |   66 
------------------------------------------------------------------

That matches d/copyright exclusions:
Files-Excluded: deps/hiredis/adapters/macosx.h
                deps/hiredis/examples/example-macosx.c

Having uscan work and do that automatically would be my preference.
Please check if that can be changed easily, given github releases/tag
pages pagination.


(continuing in next comments, saving this one)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2081000

Title:
  Backport version from Oracular to Noble

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/valkey/+bug/2081000/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to